Re: [PATCH 06/21] perf: Add event toggle ioctl interface

[Vince Weaver]

On Thu, 26 Sep 2013, Jiri Olsa wrote:

> On Wed, Sep 25, 2013 at 03:46:58PM -0400, Vince Weaver wrote:
> > On Wed, 25 Sep 2013, Jiri Olsa wrote:
> > 
> > > --- a/include/uapi/linux/perf_event.h
> > > +++ b/include/uapi/linux/perf_event.h
> > > @@ -325,6 +325,7 @@ struct perf_event_attr {
> > >  #define PERF_EVENT_IOC_SET_OUTPUT	_IO ('$', 5)
> > >  #define PERF_EVENT_IOC_SET_FILTER	_IOW('$', 6, char *)
> > >  #define PERF_EVENT_IOC_ID		_IOR('$', 7, u64 *)
> > > +#define PERF_EVENT_IOC_SET_TOGGLE	_IOW('$', 8, u64 *)
> > 
> > I'm pretty sure this should be __u64 or else it won't compile
> > in userspace.
> 
> hum, we define u64 in perf 'util/types.h', that's why I missed that..
> I'll send a fix for the PERF_EVENT_IOC_ID as well

I sent in a fix for that recently and I think it's upstream already.

That's why I noticed the issue when reviewing the perf_event.h changes.

Vince
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/