Re: [dtc PATCH V2] Warn on node name unit-address presence/absencemismatch

[Stephen Warren]

On 09/26/2013 12:21 PM, Kumar Gala wrote:
> 
> On Sep 19, 2013, at 12:54 PM, Stephen Warren wrote:
> 
>> From: Stephen Warren <swarren@xxxxxxxxxx>
>>
>> ePAPR 1.1 section 2.2.1.1 "Node Name Requirements" specifies that any
>> node that has a reg property must include a unit address in its name
>> with value matching the first entry in its reg property. Conversely, if
>> a node does not have a reg property, the node name must not include a
>> unit address.
>>
>> Implement a check for this. The code doesn't validate the format of the
>> unit address; ePAPR implies this may vary from (containing bus) binding
>> to binding, so doing so would be much more complex.

> What about the case of no reg but a ranges?
> 
> This pattern shows up on a lot (if not all) the PPC dts:
> 
> arch/powerpc/boot/dts/mpc8544ds.dts:
> 
>         board_soc: soc: soc8544@e0000000 {
>                 ranges = <0x0 0x0 0xe0000000 0x100000>;

Well, ePAPR seems pretty specific that unit address and reg are related,
but says nothing about ranges in the section on node naming, nor about
node naming in the section about ranges.

I'd claim that the existing PPC trees are nonconforming, and should be
fixed too:-)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/