Re: [PATCH] checkpatch: Make the memory barrier test noisier
From: Peter Zijlstra
Date: Fri Sep 27 2013 - 10:50:47 EST
On Fri, Sep 27, 2013 at 07:34:55AM -0700, Joe Perches wrote:
> That would make it seem as if all barriers are SMP no?
I would think any memory barrier is ordering against someone else; if
not smp then a device/hardware -- like for instance the hardware page
table walker.
Barriers are fundamentally about order; and order only makes sense if
there's more than 1 party to the game.
> Maybe just refer to Documentation/memory-barriers.txt
> and/or say something like "please document appropriately"
Documentation/memory-barriers.txt is always good; appropriately doesn't
seem to quantify anything much at all. Someone might think:
/* */
smp_mb();
appropriate...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/