Re: [PATCH 026/104] ALSA: hda - hdmi: Refactor hdmi_eld into parsed_hdmi_eld

[David Henningsson]

On 09/30/2013 01:10 PM, Luis Henriques wrote:
> Hi David,
> 
> David Henningsson <david.henningsson@xxxxxxxxxxxxx> writes:
> 
>> On 09/30/2013 12:10 PM, Luis Henriques wrote:
>>> 3.5.7.22 -stable review patch.  If anyone has any objections, please let me know.
>>>
>>> ------------------
>>>
>>> From: David Henningsson <david.henningsson@xxxxxxxxxxxxx>
>>>
>>> commit 1613d6b46b433f07f1d2703e4bd102802dcd75a4 upstream.
>>>
>>> For better readability, the information that is parsed out of the
>>> ELD data is now put into a separate parsed_hdmi_eld struct.
>>>
>>> Signed-off-by: David Henningsson <david.henningsson@xxxxxxxxxxxxx>
>>> Signed-off-by: Takashi Iwai <tiwai@xxxxxxx>
>>> [ luis: 3.5.y-prereq for:
>>>   18e3918 ALSA: hda - hdmi: Fallback to ALSA allocation when selecting CA ]
>>
>> I don't think this is really a prereq. Sorting out the fuzz in
>> hdmi_channel_allocation seems quite trivial to me, so I would suggest
>> doing so instead.
>>
>> If you do go ahead and backport this patch, a bit of testing wouldn't
>> hurt: this patch was part of a bigger patch set, and I don't think
>> anyone tested just this one without the bigger set.
> 
> Ok, I agree with you and I'm dropping this patch from the 3.5 kernel.
> Also, I'm replacing
> 
>  [PATCH 027/104] ALSA: hda - hdmi: Fallback to ALSA allocation when selecting CA
> 
> with the patch below.  Are you Ok with this?

Yes, I think it looks good.

> (btw, thank you for your review!)

Thanks for the stable backport :-)


-- 
David Henningsson, Canonical Ltd.
https://launchpad.net/~diwic
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/