Re: [PATCH] perf session: Fix infinite loop on invalid perf.datafile

From: David Ahern
Date: Mon Sep 30 2013 - 09:50:15 EST


On 9/30/13 2:19 AM, Namhyung Kim wrote:
From: Namhyung Kim <namhyung.kim@xxxxxxx>

perf-record updates the header in the perf.data file at termination.
Without this update perf-report (and other processing built-ins) it
caused an infinite loop when perf report (or something like) called.

This is because the algorithm in __perf_session__process_events()
depends on the data_size which is read from file header. Use file
size directly instead in this case to do the best-effort processing.

Cc: David Ahern <dsahern@xxxxxxxxx>
Cc: Sonny Rao <sonnyrao@xxxxxxxxxxxx>
Signed-off-by: David Ahern <dsahern@xxxxxxxxx>
Signed-off-by: Namhyung Kim <namhyung@xxxxxxxxxx>

worked ok for me. Sonny can you verify?

David

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/