Re: spinlock contention of files->file_lock

[Ingo Molnar]

* Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote:

> On Tue, Oct 01, 2013 at 02:41:58PM -0700, Eric Dumazet wrote:
> > Maybe I am missing something obvious ?
> 
> Yes.  do_execve_common() starts with unshare_files(); there can be
> no other thread capable of modifying that descriptor table.

Btw., might the Android Binder:

  drivers/staging/android/binder.c:       struct files_struct *files = proc->files;
...
  drivers/staging/android/binder.c:               __fd_install(proc->files, fd, file);
...
  drivers/staging/android/binder.c:       retval = __close_fd(proc->files, fd);

violate that assumption?

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/