Re: [PATCH 11/11] pinctrl: plgpio: Remove redundant of_match_ptr

From: Viresh Kumar
Date: Thu Oct 03 2013 - 00:37:59 EST


On 28 September 2013 17:38, Sachin Kamat <sachin.kamat@xxxxxxxxxx> wrote:
> The data structure of_match_ptr() protects is always compiled in.

of_match_ptr() isn't a data structure.. And also what does "protects" mean here?

> Hence of_match_ptr() is not needed.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@xxxxxxxxxx>
> Cc: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
> ---
> drivers/pinctrl/spear/pinctrl-plgpio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/spear/pinctrl-plgpio.c b/drivers/pinctrl/spear/pinctrl-plgpio.c
> index 0a7f0bdb..ff2940e 100644
> --- a/drivers/pinctrl/spear/pinctrl-plgpio.c
> +++ b/drivers/pinctrl/spear/pinctrl-plgpio.c
> @@ -735,7 +735,7 @@ static struct platform_driver plgpio_driver = {
> .owner = THIS_MODULE,
> .name = "spear-plgpio",
> .pm = &plgpio_dev_pm_ops,
> - .of_match_table = of_match_ptr(plgpio_of_match),
> + .of_match_table = plgpio_of_match,
> },
> };

Patch is okay otherwise.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/