Re: [PATCH 3/7] x86, kaslr: find minimum safe relocation position

From: Kees Cook
Date: Thu Oct 03 2013 - 18:43:16 EST


On Thu, Oct 3, 2013 at 3:23 PM, H. Peter Anvin <hpa@xxxxxxxxx> wrote:
> On 10/03/2013 01:53 PM, Kees Cook wrote:
>> Examine all the known unsafe areas and avoid them by just raising the
>> minimum relocation position to be past them.
>>
>> Signed-off-by: Kees Cook <keescook@xxxxxxxxxxxx>
>
>> + /* Minimum location must be above all these regions: */
>
> This is highly problematic. The standard protocol is to hoist the
> initramfs as high as possible in memory, so this may really unacceptably
> restrict the available range.

Doesn't this depend on the boot loader's behavior?

> It would be better to treat these the same as reserved regions in the
> e820 map as far as the address space picking algorithm is concerned.

Could this be considered a future optimization, or do you feel this is
required even for this first patch series landing?

-Kees

--
Kees Cook
Chrome OS Security
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/