Re: [PATCH v2 3/6] PowerCap: Added to drivers build

[Srinivas Pandruvada]

On 10/04/2013 12:24 PM, Gene Heskett wrote:
> On Friday 04 October 2013, Srinivas Pandruvada wrote:
> > Added changes to Makefile and Kconfig to include in driver build.
> >
> > Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@xxxxxxxxxxxxxxx>
> > Signed-off-by: Jacob Pan <jacob.jun.pan@xxxxxxxxxxxxxxx>
> > Acked-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
> > ---
> > drivers/Kconfig  | 2 ++
> > drivers/Makefile | 1 +
> > 2 files changed, 3 insertions(+)
> >
> > diff --git a/drivers/Kconfig b/drivers/Kconfig
> > index aa43b91..969e987 100644
> > --- a/drivers/Kconfig
> > +++ b/drivers/Kconfig
> > @@ -166,4 +166,6 @@ source "drivers/reset/Kconfig"
> >
> > source "drivers/fmc/Kconfig"
> >
> > +source "drivers/powercap/Kconfig"
> > +
> > endmenu
> > diff --git a/drivers/Makefile b/drivers/Makefile
> > index ab93de8..34c1d55 100644
> > --- a/drivers/Makefile
> > +++ b/drivers/Makefile
> > @@ -152,3 +152,4 @@ obj-$(CONFIG_VME_BUS)		+= vme/
> > obj-$(CONFIG_IPACK_BUS)		+= ipack/
> > obj-$(CONFIG_NTB)		+= ntb/
> > obj-$(CONFIG_FMC)		+= fmc/
> > +obj-$(CONFIG_POWERCAP)		+= powercap/
> I would object to this whole premise if it is not under the absolute
> control of the users program. Linuxcnc for instance is intimately married
> to a parport whose status for writes is absolutely stable from write to
> write, and whose status may be in some cases, read at sub 20 u-second
> intervals.  Anything which would imped this, puts the operator of a 50+ ton
> piece of machinery's life in jeopardy because its status is not readable in
> as close to real time as possible as it may be required to initiate a stop
> from some alarm condition before it has moved far enough to injure, maim or
> kill. 50 thousandths of an inch in further movement while moving a 70 ton
> milling machines table at 150 inches a minute is not an unreasonable
> expectation for us.
<Sorry, I didn't understand. Are you pointing any problem in this patch 
or patch-set in general?
This change added powercap directory to the kernel build. Is something 
wrong with it or any other way to do that?
>
> Cheers, Gene

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/