Re: [PATCH 26/50] tools/perf/build: Split out feature check: 'libbfd'

[Ingo Molnar]

* Jiri Olsa <jolsa@xxxxxxxxxx> wrote:

> On Mon, Oct 07, 2013 at 09:11:15AM -0600, David Ahern wrote:
> > On 10/7/13 5:56 AM, Ingo Molnar wrote:
> > >diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile
> > >index 77a2e6b..4f60ecc 100644
> > >--- a/tools/perf/config/Makefile
> > >+++ b/tools/perf/config/Makefile
> > >@@ -121,6 +121,7 @@ FEATURE_TESTS =				\
> > >  	libperl				\
> > >  	libpython			\
> > >  	libpython-version		\
> > >+	libbfd				\
> > >  	libnuma
> > >
> > >  $(foreach test,$(FEATURE_TESTS),$(call feature_check,$(test),$(test)))
> > 
> > strlcpy missing from FEATURE_TESTS, but really the strlcpy changes
> > should be a separate patch.

Indeed, that's an oversight.

> it gets removed completely in here:
>   tools/perf: Turn strlcpy() into a __weak function
> 
> still I think David's right and there should be
> separate patch for strlcpy check

Ok, I have created a separate patch for that, so that's logically 
consistent.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/