Re: [PATCH] perf tools: fix missing default initialization for tool->mmap2

[Stephane Eranian]

On Tue, Oct 8, 2013 at 2:28 PM, Arnaldo Carvalho de Melo
<acme@xxxxxxxxxx> wrote:
> Em Tue, Oct 08, 2013 at 02:02:06PM +0200, Stephane Eranian escreveu:
>> On Tue, Oct 8, 2013 at 1:59 PM, Ingo Molnar <mingo@xxxxxxxxxx> wrote:
>> >> --- a/tools/perf/util/session.c
>> >> +++ b/tools/perf/util/session.c
>> >> @@ -256,6 +256,8 @@ void perf_tool__fill_defaults(struct perf_tool *tool)
>> >>               tool->sample = process_event_sample_stub;
>> >>       if (tool->mmap == NULL)
>> >>               tool->mmap = process_event_stub;
>> >> +     if (tool->mmap2 == NULL)
>> >> +             tool->mmap2 = process_event_stub;
>> >>       if (tool->comm == NULL)
>> >>               tool->comm = process_event_stub;
>> >>       if (tool->fork == NULL)
>
>> > I think it's already fixed in tip:perf/urgent:
>
>> >   6adb0b0ae26f perf tools: Add default handler for mmap2 events
>
>> Ok, it's good then.
>> Thanks for checking.
>
> Yeah, since 'perf sched' doesn't use mmap records, just relying on the
> stub default handler is enough.
>
Yeah, exactly.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/