Re: mmap for /proc/vmcore broken since 3.12-rc1

From: Alexey Dobriyan
Date: Tue Oct 08 2013 - 08:50:01 EST


On Mon, Oct 7, 2013 at 5:42 AM, HATAYAMA Daisuke
<d.hatayama@xxxxxxxxxxxxxx> wrote:

> +static unsigned long
> +get_unmapped_area_vmcore(struct file *filp, unsigned long addr,
> + unsigned long len, unsigned long pgoff,
> + unsigned long flags)
> +{
> +#ifdef CONFIG_MMU
> + return current->mm->get_unmapped_area(filp, addr, len, pgoff,
> flags);
> +#else
> + return -EIO;
> +#endif
> +}
> +
> static const struct file_operations proc_vmcore_operations = {
> .read = read_vmcore,
> .llseek = default_llseek,
> .mmap = mmap_vmcore,
> + .get_unmapped_area = get_unmapped_area_vmcore,

I think current->mm->get_unmapped_area should be used by core proc code.
ENOMEM bug looks unrelated though.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/