Re: [PATCH v2] ARM: Dove: fix bad properties of the si5351 clkout2used by Cubox audio

From: Sebastian Hesselbarth
Date: Tue Oct 08 2013 - 14:20:06 EST


On 10/08/2013 08:20 PM, Jean-Francois Moine wrote:
As defined in the DT, clkout2 is not allowed to change the pll inside
si5351.

This patch extends the properties of clkout2 so that it works as the
external clock of the audio device in the Cubox.

Also, as the second si5351 clock is not used in the Cubox, its
definition is removed.

Signed-off-by: Jean-Francois Moine <moinejf@xxxxxxx>

Already gave my

Acked-by: Sebastian Hesselbarth <sebastian.hesselbarth@xxxxxxxxx>

which you should add to help us keep track of them next time.

---
v2:
- remove clkout1 which is not used in the Cubox (Sebastian Hesselbarth)
---
arch/arm/boot/dts/dove-cubox.dts | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/arch/arm/boot/dts/dove-cubox.dts b/arch/arm/boot/dts/dove-cubox.dts
index bb38a24..3dd8844 100644
--- a/arch/arm/boot/dts/dove-cubox.dts
+++ b/arch/arm/boot/dts/dove-cubox.dts
@@ -99,18 +99,12 @@
silabs,pll-master;
};

- clkout1 {
- reg = <1>;
- silabs,drive-strength = <8>;
- silabs,multisynth-source = <1>;
- silabs,clock-source = <0>;
- silabs,pll-master;
- };
-
clkout2 {
reg = <2>;
+ silabs,drive-strength = <8>;
silabs,multisynth-source = <1>;
silabs,clock-source = <0>;
+ silabs,pll-master;
};
};
};



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/