Re: [PATCH 0/63] Basic scheduler support for automatic NUMAbalancing V9

From: Peter Zijlstra
Date: Wed Oct 09 2013 - 08:06:11 EST


On Wed, Oct 09, 2013 at 01:03:54PM +0200, Ingo Molnar wrote:
> kernel/sched/fair.c:819:22: warning: 'task_h_load' declared 'static' but never defined [-Wunused-function]

Not too pretty, but it avoids the warning:

---
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -681,6 +681,8 @@ static u64 sched_vslice(struct cfs_rq *c
}

#ifdef CONFIG_SMP
+static unsigned long task_h_load(struct task_struct *p);
+
static inline void __update_task_entity_contrib(struct sched_entity *se);

/* Give new task start runnable values to heavy its load in infant time */
@@ -816,8 +818,6 @@ update_stats_curr_start(struct cfs_rq *c
* Scheduling class queueing methods:
*/

-static unsigned long task_h_load(struct task_struct *p);
-
#ifdef CONFIG_NUMA_BALANCING
/*
* Approximate time to scan a full NUMA task in ms. The task scan period is
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/