Re: [PATCH] perf record: mmap output file - RFC

[David Ahern]

On 10/9/13 7:33 AM, Jiri Olsa wrote:
> > +
> > +	if (size > remaining) {
> > +		memcpy(rec->mmap_addr + rec->mmap_offset, buf, remaining);
> > +		rec->bytes_written += remaining;
> > +
> > +		size -= remaining;
> > +		buf  += remaining;
> > +
> > +		msync(rec->mmap_addr, rec->mmap_size, MS_ASYNC);
> > +		munmap(rec->mmap_addr, rec->mmap_size);
>
> do we need msync call if munmap is called right away?

I was being overly cautious. I will remove it in v2.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/