Re: [PATCH v2 1/2] elevator: Fix a race in elevator switching andmd device initialization

[Tomoki Sekiyama]

Hi all,


Is this patchset going to be merged into 3.12?

Thanks,
-- 
Tomoki

On 9/23/13 16:14 , "Tejun Heo" <tj@xxxxxxxxxx> wrote:

>Hello,
>
>On Mon, Sep 23, 2013 at 08:11:55PM +0000, Tomoki Sekiyama wrote:
>> >Hmm... why aren't we just changing elevator_init() to grab sysfs_lock
>> >where necessary?
>> 
>> The locking cannot be moved into elevator_init() because it is called
>> from elevator_switch() path, where the request_queue's sysfs_lock is
>> already taken.
>> 
>> > It'd be more consistent with elevator_exit() that way.
>> 
>> What elevator_exit() locks is elevator_queue's sysfs_lock, not
>> request_queue's sysfs_lock. What we need here is request_queue's
>> sysfs_lock.
>
>Ah, okay.
>
> Reviewed-by: Tejun Heo <tj@xxxxxxxxxx>
>
>Thanks.
>
>-- 
>tejun

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/