Re: [PATCH v3a] vsprintf: Check real user/group id for %pK

From: Joe Perches
Date: Wed Oct 09 2013 - 19:22:02 EST


On Thu, 2013-10-10 at 10:18 +1100, Ryan Mallon wrote:
> On 10/10/13 10:09, Joe Perches wrote:
> > Do the in_irq tests only when kptr_restrict is 1.
> > Document the %pK mechanism in vsnprintf
> > Add missing documentation for %pV and %pNF too
>
> I really did mean post a follow-up/separate patch, not a different
> version of mine.

I think that's not the right thing to do.
There's no good reason to have multiple commits
for the same content.

And almost all of that is actually stuff I wrote.
Your content there is the cred checks.

> > + cred = current_cred();
> > + if (!has_capability_noaudit(current, CAP_SYSLOG) ||
> > + !uid_eq(cred->euid, cred->uid) ||
> > + !gid_eq(cred->egid, cred->gid))


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/