Re: [PATCH 07/52] tools/perf/build: Split out feature check:'volatile-register-var'

[Ingo Molnar]

* Namhyung Kim <namhyung@xxxxxxxxxx> wrote:

> > +test-volatile-register-var:
> > +	$(BUILD) -Werror -Wvolatile-register-var
> 
> I'm not sure this test is necessary at all.
> 
> The gcc manpage says this warning is enabled by -Wall, and we add -Wall 
> to CFLAGS before doing feature checks.  So all gcc versions that support 
> -Wvolatile-register-var enables it by default without this check and 
> older gcc versions will always fail the feature check.

Good point - I'll send a patch to remove it.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/