Re: [PATCH v6] extcon: palmas: Added a new compatible type *ti,palmas-usb-vid*

From: Laxman Dewangan
Date: Thu Oct 10 2013 - 08:46:06 EST


On Thursday 10 October 2013 06:07 PM, Kishon Vijay Abraham I wrote:
The Palmas device contains only a USB VBUS-ID detector, so added a
compatible type *ti,palmas-usb-vid*. Didn't remove the existing compatible
types for backward compatibility.

I dont have much issue on this nomenclature but just second thought:

The Palmas USB module is capable of detection VBUS, ID-GND, ID-RA, ID-RB, ID-RC and ID-FLOAT as per BC1.2.
This sub-module only detect the cable, does nothing more than this.
In this case, should we say "ti,palmas-usb-extcon"?
Again extcon is linux specific terminology and this can be defer.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/