Re: [PATCH v3 3/3] mm/zswap: avoid unnecessary page scanning

[Minchan Kim]

On Thu, Oct 10, 2013 at 12:55:06PM -0700, Andrew Morton wrote:
> On Mon, 23 Sep 2013 16:21:49 +0800 Weijie Yang <weijie.yang@xxxxxxxxxxx> wrote:
> 
> > add SetPageReclaim before __swap_writepage so that page can be moved to the
> > tail of the inactive list, which can avoid unnecessary page scanning as this
> > page was reclaimed by swap subsystem before.
> > 
> > Signed-off-by: Weijie Yang <weijie.yang@xxxxxxxxxxx>
> > Reviewed-by: Bob Liu <bob.liu@xxxxxxxxxx>
> > Cc: Minchan Kim <minchan@xxxxxxxxxx>
> > Cc: stable@xxxxxxxxxxxxxxx
> > Acked-by: Seth Jennings <sjenning@xxxxxxxxxxxxxxxxxx>
> 
> As a minor(?) performance tweak, I don't believe this is suitable for
> -stable backporting, so I took that out.  If you believe this was a
> mistake, please explain why.
> 

Yes. It's never stable stuff.

-- 
Kind regards,
Minchan Kim
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/