Re: [PATCH 02/34] cris: fix potential NULL-pointer dereference

From: Jesper Nilsson
Date: Fri Oct 11 2013 - 05:58:22 EST


On Thu, Oct 10, 2013 at 08:05:27PM +0200, Kirill A. Shutemov wrote:
> Add missing check for memory allocation fail.
>
> Signed-off-by: Kirill A. Shutemov <kirill.shutemov@xxxxxxxxxxxxxxx>
> Cc: Mikael Starvik <starvik@xxxxxxxx>

Acked-by: Jesper Nilsson <jesper.nilsson@xxxxxxxx>

> ---
> arch/cris/include/asm/pgalloc.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/cris/include/asm/pgalloc.h b/arch/cris/include/asm/pgalloc.h
> index 6da975db11..d9504d38c2 100644
> --- a/arch/cris/include/asm/pgalloc.h
> +++ b/arch/cris/include/asm/pgalloc.h
> @@ -32,6 +32,8 @@ static inline pgtable_t pte_alloc_one(struct mm_struct *mm, unsigned long addres
> {
> struct page *pte;
> pte = alloc_pages(GFP_KERNEL|__GFP_REPEAT|__GFP_ZERO, 0);
> + if (!pte)
> + return NULL;
> pgtable_page_ctor(pte);
> return pte;
> }
> --
> 1.8.4.rc3

/^JN - Jesper Nilsson
--
Jesper Nilsson -- jesper.nilsson@xxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/