Re: [PATCH 2/2] gpiolib: let gpiod_request() return -EPROBE_DEFER

From: Linus Walleij
Date: Fri Oct 11 2013 - 10:28:12 EST


On Fri, Oct 4, 2013 at 7:59 PM, Alexandre Courbot <acourbot@xxxxxxxxxx> wrote:

> Patch be1a4b brought some improvements to the GPIO error handling code,
> but also changed the return value of gpiod_request() when called on a
> not yet initialized GPIO descriptor: it now returns -EINVAL instead of
> -EPROBE_DEFER, and this affects some drivers.
>
> This patch restores the original behavior for gpiod_request(). It is
> safe to do so now that desc_to_gpio() does not rely on the GPIO
> descriptor to be initialized. Other functions changed by patch be1a4b
> do not see their return value affected, so these are not reverted.
>
> Signed-off-by: Alexandre Courbot <acourbot@xxxxxxxxxx>
> Reported-by: Dr. H. Nikolaus Schaller <hns@xxxxxxxxxxxxx>

Patch applied.

Are these two patches regressions that need to go into fixes
for v3.12?

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/