Re: [PATCH 0/6] drivers: usb: core: Adapt source to styleguide

From: Greg KH
Date: Fri Oct 11 2013 - 20:09:35 EST


On Thu, Oct 10, 2013 at 11:41:26PM +0200, Matthias Beyer wrote:
> Hi,
>
> I patches several files in drivers/usb/core/ to adapt them to the kernel
> styleguide.
>
> Most of these patches are whitespace/indention fixes.
>
> As these patches are only style-patches, I just compiled the kernel, no compile
> errors or warnings. So I think everything seems to be okay!
>
> Note: I did not fix all ERROR messages from the scripts/checkpatch.pl script, as
> I don't know what to do with "do not use assignments in if-condition" messages.

You can fix those up if you want. An example would be:
bad code:
if ((x = foo() == NULL)
do_something();
good code:
x = foo();
if (x == NULL)
do_something();

Hope this helps,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/