Re: [PATCH] cpufreq: fix false return check from "regulator_set_voltage"

[Viresh Kumar]

On 09/10/2013, Manish Badarkhe <badarkhe.manish@xxxxxxxxx> wrote:
> Currently, code checks false return value from "regulator_set_voltage"
> to show failure message. Modify the code to check proper return
> value from "regulator_set_voltage".
>
> Signed-off-by: Manish Badarkhe <badarkhe.manish@xxxxxxxxx>
> ---
> Based on master branch of linux-mainline.
>
> :100644 100644 0fac344... 1537f32... M	drivers/cpufreq/exynos-cpufreq.c
>  drivers/cpufreq/exynos-cpufreq.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/exynos-cpufreq.c
> b/drivers/cpufreq/exynos-cpufreq.c
> index 0fac344..1537f32 100644
> --- a/drivers/cpufreq/exynos-cpufreq.c
> +++ b/drivers/cpufreq/exynos-cpufreq.c
> @@ -141,7 +141,7 @@ post_notify:
>  	if ((freqs.new < freqs.old) ||
>  	   ((freqs.new > freqs.old) && safe_arm_volt)) {
>  		/* down the voltage after frequency change */
> -		regulator_set_voltage(arm_regulator, arm_volt,
> +		ret = regulator_set_voltage(arm_regulator, arm_volt,
>  				arm_volt);
>  		if (ret) {
>  			pr_err("%s: failed to set cpu voltage to %d\n",

Acked-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/