Re: [PATCH 1/2] i2c designware make SCL and SDA falling time configurable

[Shinya Kuribayashi]

On 10/10/13 9:54 AM, Ryan Mallon wrote:
> On 09/10/13 18:55, Mika Westerberg wrote:
> > On Tue, Oct 08, 2013 at 05:00:54PM +0200, Romain Baeriswyl wrote:
> > > @@ -307,15 +309,25 @@ int i2c_dw_init(struct dw_i2c_dev *dev)
> > >
> > >   	/* set standard and fast speed deviders for high/low periods */
> > >
> > > +	if (dev->sda_falling_time)
> > > +		sda_falling_time = dev->sda_falling_time;
> > > +	else
> > > +		sda_falling_time = 300; /* ns */
> >
> > I think this looks better:
> >
> > 	sda_falling_time = dev->sda_falling_time ? dev->sda_falling_time : 300;
>
> You can also use the gcc-ism, which is a bit more concise:
>
> 	sda_falling_time = dev->sda_falling_time ?: 300;

+1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/