[PATCH v2 net-next] fib_trie: remove duplicated rcu lock

From: baker . kernel
Date: Sun Oct 13 2013 - 07:50:41 EST


From: "baker.zhang" <baker.kernel@xxxxxxxxx>

fib_table_lookup has included the rcu lock protection.

Signed-off-by: baker.zhang <baker.kernel@xxxxxxxxx>
---
Thanks for Eric Dumazet's review.
The V1 patch remove a necessary rcu read lock.

net/ipv4/fib_frontend.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/net/ipv4/fib_frontend.c b/net/ipv4/fib_frontend.c
index b3f627a..d846304 100644
--- a/net/ipv4/fib_frontend.c
+++ b/net/ipv4/fib_frontend.c
@@ -933,7 +933,6 @@ static void nl_fib_lookup(struct fib_result_nl *frn, struct fib_table *tb)
local_bh_disable();

frn->tb_id = tb->tb_id;
- rcu_read_lock();
frn->err = fib_table_lookup(tb, &fl4, &res, FIB_LOOKUP_NOREF);

if (!frn->err) {
@@ -942,7 +941,6 @@ static void nl_fib_lookup(struct fib_result_nl *frn, struct fib_table *tb)
frn->type = res.type;
frn->scope = res.scope;
}
- rcu_read_unlock();
local_bh_enable();
}
}
--
1.8.1.2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/