Re: [PATCH 1/6] net: ip4_datagram_connect: Use correct form ofstatistics update

[Eric Dumazet]

On Wed, 2013-10-16 at 14:27 +0000, Christoph Lameter wrote:
> Same issue in ipv6 code.
> 
> 
> Subject: net: Fix statistics update in ip6
> 
> ipv6 does the same as ipv4. IP6_INC_STATS must be used outside
> of BH sections.
> 
> Signed-off-by: Christoph Lameter <cl@xxxxxxxxx>
> 

Missing separator "---"

> Index: linux/net/ipv6/ip6_output.c
> ===================================================================
> --- linux.orig/net/ipv6/ip6_output.c	2013-10-10 11:01:01.119771564 -0500
> +++ linux/net/ipv6/ip6_output.c	2013-10-16 08:48:19.474562100 -0500
> @@ -909,7 +909,7 @@ static int ip6_dst_lookup_tail(struct so
> 
>  out_err_release:
>  	if (err == -ENETUNREACH)
> -		IP6_INC_STATS_BH(net, NULL, IPSTATS_MIB_OUTNOROUTES);
> +		IP6_INC_STATS(net, NULL, IPSTATS_MIB_OUTNOROUTES);
>  	dst_release(*dst);
>  	*dst = NULL;
>  	return err;

Yes, bug added in commit ca46f9c834913fc5
("[IPv6] SNMP: Increment OutNoRoutes when connecting to unreachable
network")

Your inability to cc netdev for netdev patches is really irritating,
you do know that, right ?



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/