Re: [PATCH 5/5] sched: Avoid throttle_cfs_rq racing withperiod_timer stopping

From: Peter Zijlstra
Date: Wed Oct 16 2013 - 18:06:23 EST


On Wed, Oct 16, 2013 at 11:16:32AM -0700, Ben Segall wrote:
> +#ifdef CONFIG_CFS_BANDWIDTH
> + SEQ_printf(m, " .%-30s: %d\n", "tg->cfs_bandwidth.timer_active",
> + cfs_rq->tg->cfs_bandwidth.timer_active);
> + SEQ_printf(m, " .%-30s: %d\n", "throttled",
> + cfs_rq->throttled);
> + SEQ_printf(m, " .%-30s: %d\n", "throttle_count",
> + cfs_rq->throttle_count);
> +#endif

Not really your fault; but that function just cries for something like:

#define SEQ_cfs_rq(m, member) \
SEQ_printf(m, " .%-30s: %ld\n", #member, (long)cfs_rq->member)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/