Re: [PATCH 1/2] tracing: creates 'tracing_is_disabled()'

From: Geyslan GregÃrio Bem
Date: Fri Oct 18 2013 - 20:22:07 EST


2013/10/18 Steven Rostedt <rostedt@xxxxxxxxxxx>:
> On Fri, 18 Oct 2013 17:59:41 -0300
> "Geyslan G. Bem" <geyslan@xxxxxxxxx> wrote:
>
>> This patch creates the function 'tracing_is_disabled ", which
>> can be used outside trace.c.
>>
>> Signed-off-by: Geyslan G. Bem <geyslan@xxxxxxxxx>
>> ---
>> kernel/trace/trace.c | 5 +++++
>> kernel/trace/trace.h | 1 +
>> 2 files changed, 6 insertions(+)
>>
>> diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
>> index 7974ba2..a120a73 100644
>> --- a/kernel/trace/trace.c
>> +++ b/kernel/trace/trace.c
>> @@ -2964,6 +2964,11 @@ int tracing_open_generic(struct inode *inode, struct file *filp)
>> return 0;
>> }
>>
>> +inline bool tracing_is_disabled(void)
>
> Nuke the "inline". Gcc and other compilers are smart enough to know to
> inline it on a -O2, that we don't need it. Especially, when it's used
> in another file.
>
> -- Steve

Done. Version 3 sent.

Thanks.
>> +{
>> + return (tracing_disabled) ? true: false;
>> +}
>> +
>> /*
>> * Open and update trace_array ref count.
>> * Must have the current trace_array passed to it.
>> diff --git a/kernel/trace/trace.h b/kernel/trace/trace.h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/