Re: [bug] get_maintainer.pl incomplete output

From: Joe Perches
Date: Fri Oct 18 2013 - 20:26:07 EST


On Fri, 2013-10-18 at 15:58 -0700, David Rientjes wrote:
> On Thu, 17 Oct 2013, Joe Perches wrote:
> > Try this:
> > It adds authored/lines_added/lines_deleted to rolestats
> > For instance:
> > $ ./scripts/get_maintainer.pl -f mm/vmpressure.c
> > Tejun Heo <tj@xxxxxxxxxx> (commit_signer:6/7=86%,authored:3/7=43%,removed_lines:15/21=71%)
> > Michal Hocko <mhocko@xxxxxxx> (commit_signer:5/7=71%,authored:3/7=43%,added_lines:22/408=5%,removed_lines:6/21=29%)
> > Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> (commit_signer:4/7=57%)
> > Li Zefan <lizefan@xxxxxxxxxx> (commit_signer:3/7=43%)
> > "Kirill A. Shutemov" <kirill@xxxxxxxxxxxxx> (commit_signer:1/7=14%)
> > Anton Vorontsov <anton.vorontsov@xxxxxxxxxx> (authored:1/7=14%,added_lines:374/408=92%)
> > linux-mm@xxxxxxxxx (open list:MEMORY MANAGEMENT)
> > linux-kernel@xxxxxxxxxxxxxxx (open list)
> >
> > I haven't tested it much.
> This looks good, thanks very much!

Oh sure, it's a trifle.

> I'm not sure how useful the
> removed_lines stat is, but perhaps it can be useful for someone to chime
> in if someone proposes a patch that includes support that had already been
> removed.

The whole concept of lines +/- is kind of dubious.
Quantity really doesn't judge value.

It makes some sense for patches where new files
are added, but new files are a relatively a small
percentage of the overall kernel source tree.

Let it stew for awhile in Andrew's tree and when
-next opens up again, let's see if there are any
other comments about it.

My guess is very few people will notice.

The best mechanism is to have MAINTAINERS entries.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/