RE: [PATCH v3 8/9] ACPI, APEI, CPER: Cleanup CPER memory erroroutput format

From: Luck, Tony
Date: Mon Oct 21 2013 - 13:14:11 EST


>>>> + if (severity != CPER_SEV_FATAL)
>>>
>>> Shouldn't this just be (severity == CPER_SEV_CORRECTED)?


>> IMO, only fatal error can't be handlered gracefully in current
>> kernel plus H/W. Once it can be recovered by H/W and OS, we
>> can call it recovered.

> Sure, but we don't recover in all scenarios. So, calling it corrected
> seems incorrect to me.

Even if we recovered from a UC error (which is by no means a sure
thing) ... I don't think the "requires no further action" message applies.

Soft single bit errors are common (well, common-ish ... they should still
be somewhat rare by most objective standard). Double bit errors are
much rarer ... and are very unlikely to be the result of two single bit errors
happening to be inside the same cache line. I'd recommend further investigation
of the source of a UC error (even one that is "recovered" in software).

-Tony
èº{.nÇ+‰·Ÿ®‰­†+%ŠËlzwm…ébëæìr¸›zX§»®w¥Š{ayºÊÚë,j­¢f£¢·hš‹àz¹®w¥¢¸ ¢·¦j:+v‰¨ŠwèjØm¶Ÿÿ¾«‘êçzZ+ƒùšŽŠÝj"ú!¶iO•æ¬z·švØ^¶m§ÿðà nÆàþY&—