Re: [PATCH] block/aio: Enable sysfs nomerge control for I/O requestsin the plug list

From: Jens Axboe
Date: Wed Oct 23 2013 - 12:10:55 EST


On Wed, Oct 23 2013, Jeff Moyer wrote:
> Alireza Haghdoost <alireza@xxxxxxxxxx> writes:
>
> > This patch enables the sysfs to control I/O request merge
> > functionality in the plug list. While this control has been
> > implemented for the request queue, it was dismissed in the plug list.
> > Therefore, block layer merges requests together (or attempt to merge)
> > even if the merge capability was disable using sysfs nomerge parameter
> > value 2.
>
> Yeah, this looks like an oversight. Your mailer really munged up the
> patch, though. You should fix that and resend (unless Jens just fixes
> it up manually). Also, please specify the -p option to diff or just use
> git diff.

I fixed it up, changed the style slightly as well (no point in reading
and checking the plug first). This is what I queued up:

http://git.kernel.dk/?p=linux-block.git;a=commit;h=dfc302d833c46f40b5f775099da00bb0cf0e81ad

--
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/