Re: [PATCH v3 3/4] perf,x86: add Intel RAPL PMU support

[Stephane Eranian]

On Fri, Oct 25, 2013 at 1:14 PM, Jiri Olsa <jolsa@xxxxxxxxxx> wrote:
> On Wed, Oct 23, 2013 at 02:58:04PM +0200, Stephane Eranian wrote:
>
> SNIP
>
>> +
>> +static void rapl_init_cpu(int cpu)
>> +{
>> +     int i, phys_id = topology_physical_package_id(cpu);
>> +
>> +     spin_lock(&rapl_hotplug_lock);
>> +
>> +     /* check if phys_is is already covered */
>> +     for_each_cpu(i, &rapl_cpu_mask) {
>> +             if (phys_id == topology_physical_package_id(i))
>> +                     return;
>
> missing 'spin_unlock(&rapl_hotplug_lock)' above
>
Good catch. I fixed that now.

>> +     }
>> +     /* was not found, so add it */
>> +     cpumask_set_cpu(cpu, &rapl_cpu_mask);
>> +
>> +     spin_unlock(&rapl_hotplug_lock);
>> +}
>> +
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/