[PATCHSET 0/5] perf tools: Enhance option parsing error message

From: Namhyung Kim
Date: Fri Nov 01 2013 - 03:33:25 EST


This patchset tries to enhance error message when perf failed to parse
option argument. Currently it just shows entire usage and options
which may fill two pages of screen. It's hard for me to say it's
really helpful to users. ;-)

With this patch series, it changed to show only related option(s).
There're also more points to improve yet - like auto-breaking long
lines, dealing with UIs and so on. But I believe this will be a good

$ perf report -g help

usage: perf report [<options>]

-g, --call-graph <output_type,min_percent[,print_limit],call_order>
Display callchains using output_type (graph, flat, fractal, or none) , min percent threshold, optional print limit, callchain order, key (function or address). Default: fractal,0.5,callee,function

$ perf stat -Bx, ls
-B option not supported with -x

usage: perf stat [<options>] [<command>]

-B, --big-num print large numbers with thousands' separators
-x, --field-separator <separator>
print counts with custom separator

You can get this on 'perf/option-v1' branch in my tree



Namhyung Kim (5):
perf tools: Show single option when failed to parse
perf report: Postpone setting up browser after parsing options
perf report: Use parse_options_usage() for -s option failure
perf top: Use parse_options_usage() for -s option failure
perf stat: Enhance option parse error message

tools/perf/builtin-report.c | 30 +++---
tools/perf/builtin-stat.c | 42 +++++---
tools/perf/builtin-top.c | 8 +-
tools/perf/util/parse-options.c | 218 ++++++++++++++++++++++++----------------
tools/perf/util/parse-options.h | 4 +-
5 files changed, 181 insertions(+), 121 deletions(-)


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/