Re: [PATCH v2 1/2] extcon: arizona: Fix reset of HPDET after racewith removal

From: Charles Keepax
Date: Mon Nov 04 2013 - 04:21:09 EST

On Mon, Nov 04, 2013 at 09:32:50AM +0900, Chanwoo Choi wrote:
> The arizona_hpdet_do_id() return only either -EAGIN or 0(zero).
> extcon-arizona driver could never execute 'goto done;' statement.
> ret = arizona_hpdet_do_id(info, &reading, &mic);
> if (ret == -EAGAIN) {
> goto out;
> } else if (ret < 0) {
> goto done;
> }

True that else if is redundant at the moment, but personally I
would be inclined to leave it in, it feels safer against possible
future edits of arizona_hpdet_do_id. It would be reasonable for
someone to assume that other return values are acceptable whilst
editing it but they would then not be handled.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at