Re: [tip:perf/core] tools/perf: Add required memory barriers
From: Peter Zijlstra
Date: Wed Nov 06 2013 - 10:11:31 EST
On Wed, Nov 06, 2013 at 09:55:17AM -0500, Vince Weaver wrote:
> Having perf in the kernel tree really makes it hard for you guys to keep a
> clean API/ABI it seems.
Lock free buffers are 'fun'.. The ABI can be described as:
// ensure no other reads get before this point and ->data_head
// doesn't get re-read hereafter.
read data; using pc->data_tail, until the read head value.
// ensure all reads are completed before issuing
How you want to implement that on your compiler/arch combination is up
to you. Like said, C11 has the __atomic bits you can use to implement
this in proper C; barring that, you'll have to get creative and use
assembly one way or another.
On x86/sparc/s390 which have relatively strong memory models its fairly
easy, on powerpc/arm which have much weaker models its more fun.
This isn't actually something that has changed; its just that we
recently found some implementations thereof were buggy.
We provide an implementation in GNU C, if you want to use something else
you get to deal with that other compiler.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/