Re: [PATCH 1/2] clockevent: sun4i: Fill the irq field in the clockeventstructure

From: Daniel Lezcano
Date: Thu Nov 07 2013 - 05:17:38 EST

On 10/25/2013 01:16 PM, Maxime Ripard wrote:
The clock event structure irq field was not filled previously to the
interrupt we're using.

This was resulting in the timer not being used at all when using a
configuration with SMP enabled on a system with several CPUs, and with
the cpumask set to the cpu_possible_mask.

Signed-off-by: Maxime Ripard <maxime.ripard@xxxxxxxxxxxxxxxxxx>

Applied to my tree for 3.14

drivers/clocksource/sun4i_timer.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/clocksource/sun4i_timer.c b/drivers/clocksource/sun4i_timer.c
index 2fb4695..a7f492e 100644
--- a/drivers/clocksource/sun4i_timer.c
+++ b/drivers/clocksource/sun4i_timer.c
@@ -188,6 +188,7 @@ static void __init sun4i_timer_init(struct device_node *node)
writel(val | TIMER_IRQ_EN(0), timer_base + TIMER_IRQ_EN_REG);

sun4i_clockevent.cpumask = cpumask_of(0);
+ sun4i_clockevent.irq = irq;

clockevents_config_and_register(&sun4i_clockevent, rate,
TIMER_SYNC_TICKS, 0xffffffff);

<> â Open source software for ARM SoCs

Follow Linaro: <> Facebook |
<!/linaroorg> Twitter |
<> Blog

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at