Re: [PATCH 2/2] LEDS: tca6502: add device-tree support for GPIOconfiguration.
Date: Thu Nov 07 2013 - 18:46:34 EST
On Thu, 7 Nov 2013 15:39:00 -0800 Bryan Wu <cooloney@xxxxxxxxx> wrote:
> On Thu, Oct 31, 2013 at 7:41 PM, NeilBrown <neilb@xxxxxxx> wrote:
> [PATCH 2/2] LEDS: tca6502: add device-tree support for GPIO configuration.
> I think it should be tca6507, right? Typo?
Obviously I'm still dreaming of the Apple IIe. Yes, a typo.
> For other parts of this patch, I'm OK for them.
> And just a quick scan of the leds-tca6507, I found bunch of typos in
> the comments:
> * An led-tca6507 device must be provided with platform data. This data
> * lists for each output: the name, default trigger, and whether the signal
> * is being used as a GPiO rather than an led. 'struct led_plaform_data'
> Can we unify to use GPIO and gpio?
> * is used for this. If 'name' is NULL, the output isn't used. If 'flags'
> * is TCA6507_MAKE_CPIO, the output is a GPO.
> Here should be TCA6507_MAKE_GPIO and GPIO instead of GPO
> * The "struct led_platform_data" can be embedded in a
> * "struct tca6507_platform_data" which adds a 'gpio_base' for the GPiOs,
> * and a 'setup' callback which is called once the GPiOs are available.
> Don't use GPiO, please.
> Could you please review the code again and submit a cleanup patch to
> fix those typos?
Yes, I'll send a patch shortly.
Description: PGP signature