Re: [trivial PATCH] module.h: Remove unnecessary semicolon
From: Rusty Russell
Date: Thu Nov 07 2013 - 18:51:19 EST
Joe Perches <joe@xxxxxxxxxxx> writes:
> On Thu, 2013-11-07 at 12:32 +1030, Rusty Russell wrote:
>> Joe Perches <joe@xxxxxxxxxxx> writes:
>> > This semicolon isn't necessary, remove it.
>> > Signed-off-by: Joe Perches <joe@xxxxxxxxxxx>
>> This is a terrible description. Really bad.
> I'd've preferred no description.
>> First, it just repeats the subject, with more words.
> Which others have demanded.
>> Second, it gives me no indication that you've done a grep to make sure
>> noone is abusing the macro, so I can't apply it without doing that check
> That's a trust issue.
> I've done it. It isn't necessary.
WTF? Now you just said it's not necessary, I *know* I can't trust you.
> The other #define module_put_and_exit in a
> different #if #else already doesn't have one.
You didn't mention this, and even if you did, it's not sufficient. Some
code only ever gets compiled as a module, so it'd never hit the
> Trust it or not, apply it or not.
Now I know when I receive a patch from you I have to check it carefully,
because you can't be bothered.
I've fixed your patch, you can find it below.
From: Joe Perches <joe@xxxxxxxxxxx>
Subject: module.h: Remove unnecessary semicolon
[All 8 callers already have semicolons. -- RR]
Signed-off-by: Joe Perches <joe@xxxxxxxxxxx>
Signed-off-by: Rusty Russell <rusty@xxxxxxxxxxxxxxx>
include/linux/module.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/module.h b/include/linux/module.h
index 15cd6b1b211e..46e548fd502a 100644
@@ -451,7 +451,7 @@ int module_kallsyms_on_each_symbol(int (*fn)(void *, const char *,
extern void __module_put_and_exit(struct module *mod, long code)
-#define module_put_and_exit(code) __module_put_and_exit(THIS_MODULE, code);
+#define module_put_and_exit(code) __module_put_and_exit(THIS_MODULE, code)
unsigned long module_refcount(struct module *mod);
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/