Re: [PATCH 2/2] mfd: max77693: reorder params in API for regmapconsistency

From: Lee Jones
Date: Fri Nov 08 2013 - 10:54:17 EST


On Fri, 08 Nov 2013, Krzysztof Kozlowski wrote:

> The last two parameters of certain register access functions were in
> different order than regmap API. This was confusing and error-prone.
>
> Reorder parameters for register access API to match regmap API:
> - max77693_bulk_read() reorder count and buf,
> - max77693_bulk_write() reorder count and buf,
> - max77693_update_reg() reorder val and mask.
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx>
> Signed-off-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx>
> ---
> drivers/extcon/extcon-max77693.c | 14 +++++++-------
> drivers/mfd/max77693-irq.c | 2 +-
> drivers/mfd/max77693.c | 6 +++---
> include/linux/mfd/max77693-private.h | 10 +++++-----
> 4 files changed, 16 insertions(+), 16 deletions(-)

Acked-by: Lee Jones <lee.jones@xxxxxxxxxx>

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/