Re: [PATCH v5 4/4] qrwlock: Use the mcs_spinlock helper functionsfor MCS queuing

From: Tim Chen
Date: Fri Nov 08 2013 - 20:17:17 EST


On Fri, 2013-11-08 at 13:21 -0800, Paul E. McKenney wrote:
> On Mon, Nov 04, 2013 at 12:17:20PM -0500, Waiman Long wrote:
> > There is a pending patch in the rwsem patch series that adds a generic
> > MCS locking helper functions to do MCS-style locking. This patch
> > will enable the queue rwlock to use that generic MCS lock/unlock
> > primitives for internal queuing. This patch should only be merged
> > after the merging of that generic MCS locking patch.
> >
> > Signed-off-by: Waiman Long <Waiman.Long@xxxxxx>
>
> This one does might address at least some of the earlier memory-barrier
> issues, at least assuming that the MCS lock is properly memory-barriered.

Paul, will appreciate if you can take a look the latest version
of MCS lock with load-acquire and store-release to see if it is now
properly memory-barriered.

Thanks.

Tim

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/