Re: [PATCH] staging: comedi: fix potentially uninitialised variable

From: Dan Carpenter
Date: Sun Nov 10 2013 - 17:00:48 EST


On Sun, Nov 10, 2013 at 07:37:49PM +0100, Michal Nazarewicz wrote:
> From: Michal Nazarewicz <mina86@xxxxxxxxxx>
>
> If none of the if conditions take a true path, the ret variable will
> never be assigned a value.

Don't use a From: unless you are sending it on behalf of another sender.

You need a Signed-off-by line and it has to match your email address
which you used to send the email.

Otherwise, the patch is good an fixes an important bug.

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/