Re: [PATCH] uprobes: Cleanup !CONFIG_UPROBES decls, unexport xol_area

From: Srikar Dronamraju
Date: Mon Nov 11 2013 - 02:26:51 EST


* Oleg Nesterov <oleg@xxxxxxxxxx> [2013-11-09 20:03:44]:

> 1. Don't include asm/uprobes.h unconditionally, we only need
> it if CONFIG_UPROBES.
>
> 2. Move the definition of "struct xol_area" into uprobes.c.
>
> Perhaps we should simply kill struct uprobes_state, it buys
> nothing.
>
> 3. Kill the dummy definition of uprobe_get_swbp_addr(), nobody
> except handle_swbp() needs it.
>
> 4. Purely cosmetic, but move the decl of uprobe_get_swbp_addr()
> up, close to other __weak helpers.
>
> Signed-off-by: Oleg Nesterov <oleg@xxxxxxxxxx>

Acked-by: Srikar Dronamraju <srikar@xxxxxxxxxxxxxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/