Re: [PATCH 1/2] firmware: Introduce request_firmware_direct()

From: Ming Lei
Date: Mon Nov 11 2013 - 02:44:49 EST


Hi Takashi,

On Tue, Nov 5, 2013 at 7:57 PM, Takashi Iwai <tiwai@xxxxxxx> wrote:
> When CONFIG_FW_LOADER_USER_HELPER is set, request_firmware() falls
> back to the usermode helper for loading via udev when the direct
> loading fails. But the recent udev takes way too long timeout (60
> seconds) for non-existing firmware. This is unacceptable for the
> drivers like microcode loader where they load firmwares optionally,
> i.e. it's no error even if no requested file exists.
>
> This patch provides a new helper function, request_firmware_direct().
> It behaves as same as request_firmware() except for that it doesn't
> fall back to usermode helper but returns an error immediately if the
> f/w can't be loaded directly in kernel.
>
> Without CONFIG_FW_LOADER_USER_HELPER=y, request_firmware_direct() is
> just an alias of request_firmware(), due to obvious reason.
>
> Tested-by: Prarit Bhargava <prarit@xxxxxxxxxx>
> Signed-off-by: Takashi Iwai <tiwai@xxxxxxx>

The patch is fine, except it should be against -next, so you can feel
free to add my Acked-by in your next submission.

Thanks,
--
Ming Lei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/