Re: [PATCH 09/17] [m68k] IRQ: add handle_polled_irq() for timer based soft interrupts

From: Michael Schmitz
Date: Wed Nov 13 2013 - 02:57:44 EST


Thomas,

I suppose setting the flag can be done in the corresponding irq startup
function, instead of when setting up the irq controller?

irq_startup() is called with irq_desc->lock held and
irq_set_status_flags() wants desc->lock as well. Deadlock

Thanks, point taken.

And no, you don't want to fiddle manually in the irq descriptor data
fields. See commit a6967caf00eb :)

I'm not that crazy :-)


Geert - I will send the patch to ataints.c implementing this as soon as
Thomas' fix is merged.

I'll expedite it for 3.13.

Thanks, that'll help.

Cheers,

Michael



Thanks,

tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/