Re: [PATCH] regmap: Fix 'ret' would return an uninitialized value
From: Mark Brown
Date: Thu Nov 14 2013 - 07:58:28 EST
On Mon, Nov 11, 2013 at 11:35:52AM +0000, Caizhiyong wrote:
> + int ret = 0;
With the if statement below you probably don't need to do this any more.
> + if (num_regs <= 0) {
> + WARN_ONCE(1, "Call regmap_register_patch with num_regs <= 0.");
> + return 0;
> + }
WARN_ONCE actually returns the result of the test so you should be able
to write this as:
if (WARN_ONCE(num_regs <= 0))
return 0;
which is slightly neater.
Attachment:
signature.asc
Description: Digital signature