Re: [PATCH] ramfs: Fix memory leak on ramfs_fill_super error paths

From: Al Viro
Date: Thu Nov 14 2013 - 09:10:20 EST


On Thu, Nov 14, 2013 at 02:59:19PM +0800, Axel Lin wrote:
> The memory leak was introduced by commit 318ceed0884
> "tidy up after d_make_root() conversion".

No memory leaks there. Note that ->kill_sb() is called in *all*
cases, so that kfree() will be done by it just fine.

It's *not* ->put_super() - that would've been called only for superblocks
that had passed mount. ->kill_sb() is called for *all* of them and
that often simplifies cleanup on failure exits quite nicely.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/