Re: perf code using smp_processor_id() in preemptible [00000000] code

[Cyrill Gorcunov]

On Fri, Nov 15, 2013 at 11:02:54AM +0100, Peter Zijlstra wrote:
> On Thu, Nov 14, 2013 at 10:29:07PM -0500, Dave Jones wrote:
> > BUG: using smp_processor_id() in preemptible [00000000] code: trinity-main/890
> > caller is p4_pmu_schedule_events+0x25/0x4c0
> 
> Whee, wherever did you dig up that dinosaur ;-)

rofl ;)
> 
> Hrmm, I'm not entire sure what we should do here; Cyrill, do you have clue?

We need figure out which cpu we're scheduled on to properly choose thread.
I have a vague memory that earlier I've raw_smp_processor_id here but then
someone pointed that we need smp_processor_id instead. Gimme some time,
I'll cook a patch today.

Thanks for report, Dave!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/