Re: [RFC][PATCH 11/13] dump_skip(): dump_seek() replacement taking coredump_params

[Geert Uytterhoeven]

Hi Al,

On Wed, Oct 9, 2013 at 2:15 AM, Al Viro <viro@xxxxxxxxxxxxxxxx> wrote:
> --- a/fs/coredump.c
> +++ b/fs/coredump.c

> @@ -714,32 +706,25 @@ int dump_emit(struct coredump_params *cprm, const void *addr, int nr)
>  }
>  EXPORT_SYMBOL(dump_emit);
>
> -int dump_seek(struct file *file, loff_t off)
> +int dump_skip(struct coredump_params *cprm, size_t nr)
>  {
> -       int ret = 1;
> -
> +       static char zeroes[PAGE_SIZE];

Do we really need this to be static?

It's at the top of my v3.12.. bloat-o-meter report:

function                                     old     new   delta
static.zeroes                                  -    4096   +4096

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/