Re: [PATCH v2 10/13] kprobes: Remove uneeded kernel dependency onstruct arch_specific_insn

From: David Long
Date: Fri Nov 15 2013 - 10:17:07 EST


On 11/15/13 05:23, Masami Hiramatsu wrote:
I see. I'd just like to suggest you that your improvement on ONE arch
can also be useful idea for the other archs. In that case, there would be
better, more efficient way to do that.
Since we are on the same (or, next) track, we can learn many things each other. :)

Thank you,


I'd like to suggest there is still no reason not to take the current work (with suggested changes), which interested parties can then further adapt for supporting other/multiple architectures. There is virtually no new architecture-specific code that would have to be redone later. Additionally, it's not clear to me how useful instruction interpretation is to any other architecture. We are doing this only because 32-bit ARM does not support single-stepping.

-dl

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/